Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds redirects for other old embed routes #930

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Adds redirects for other old embed routes #930

merged 4 commits into from
Dec 4, 2024

Conversation

eyeseast
Copy link
Collaborator

@eyeseast eyeseast commented Dec 4, 2024 •
edited
Loading

This catches a few more we found today.

Also closes #928, closes #932, closes #932

@netlify Netlify
Copy link

netlify bot commented Dec 4, 2024 •
edited
Loading

✅ Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 6ff8921
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend-next/deploys/67506e7e7b2f960008821051
😎 Deploy Preview https://deploy-preview-930.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 19 (🔴 down 35 from production)
Accessibility: 86 (🟢 up 1 from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.73% 6727 / 21884
🔵 Statements 30.73% 6727 / 21884
🔵 Functions 49.01% 275 / 561
🔵 Branches 74.87% 1013 / 1353
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/viewer/ReadingToolbar.svelte 0% 0% 0% 0% 1-151
src/lib/components/viewer/ViewerContext.svelte 0% 0% 0% 0% 1-198
src/routes/(app)/documents/[id]-[slug]/annotations/[note_id]/+page.ts 0% 0% 0% 0% 1
src/routes/(app)/documents/[id]-[slug]/pages/[page]/+page.ts 0% 0% 0% 0% 1
src/routes/embed/documents/[id]/pages/[page]/+page.svelte 0% 0% 0% 0% 1-180
Generated in workflow #437 for commit 6ff8921 by the Vitest Coverage Report Action

@eyeseast eyeseast mentioned this pull request Dec 4, 2024
Closed
@eyeseast eyeseast mentioned this pull request Dec 4, 2024
Closed
@allanlasser allanlasser linked an issue Dec 4, 2024 that may be closed by this pull request
DocumentCloud search interface missing element at certain breakpoints #931
Closed
@eyeseast @allanlasser
logging
6ff8921 
Co-authored-by: Allan Lasser <[email protected]>
@eyeseast eyeseast merged commit ba7cba2 into main Dec 4, 2024
10 of 11 checks passed
@allanlasser allanlasser mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanlasser allanlasser allanlasser left review comments

@mitchelljkotler mitchelljkotler Awaiting requested review from mitchelljkotler

@duckduckgrayduck duckduckgrayduck Awaiting requested review from duckduckgrayduck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eyeseast @allanlasser